-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook: Add BlockImage
component (as well as Fancybox)
#38
Conversation
adding fancybox dependencies
changing setting to use full bleed image data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @laespinoza86, this is great! Also a nice feature for those who need easy modals.
I had some thoughts about the LayoutHelper
class, and I also think we should eventually add a story for the Fancybox Button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @laespinoza86 !
BlockImage
componentBlockImage
component
BlockImage
componentBlockImage
component (as well as Fancybox)
Checklist
Description
Adding
BlockImage
to our components list. This PR also adds Fancybox (scss and template classes taken from WCP), addresses issue #33 .Instructions to test
npm run storybook
View it under
Components > Blocks > BlockImage
You can test the lightbox option by clicking on the expand icon in the top right corner of the image.
WWW Storybook equivalent: https://designlab.jpl.nasa.gov/storybook/?path=/docs/components-blocks-blockimage--streamfield-block
Tested in the following environments/browsers:
Operating System
Browser