Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to Storybook 8, Tailwind 3, and npm v20+ #428

Merged
merged 10 commits into from
May 15, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented May 14, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

This work is the first step in prepping Explorer-1 for EDU development: https://github.com/nasa-jpl/www/issues/10

Instructions to test

  1. delete your node_modules folder
  2. nvm install 20.13.1
  3. nvm use
  4. npm i
  5. npm run build
  6. npm run storybook

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

- recreate theme selection capability
- fix react component renderer
- use dynamic descriptions
- convert mdx
- fix links within stories
- fix js mounting

restoring designlab branding theme

Restoring markdown in Description
@stephiescastle stephiescastle marked this pull request as draft May 14, 2024 01:15
@github-actions github-actions bot added maintenance The meta work of maintaining the project storybook This issue relates to Storybook.js labels May 14, 2024
@stephiescastle stephiescastle added the major Contains breaking changes from previous release label May 14, 2024
@stephiescastle stephiescastle changed the title chore: Upgrade to Storybook 8 and Tailwind 3 chore: Upgrade to Storybook 8, Tailwind 3, and npm v20+ May 14, 2024
- clean up and restoring html viewer
- cleaning up docs in storybook
- fixing percy integration
@stephiescastle
Copy link
Member Author

Link to visual regression test: https://percy.io/e5a03e0a/explorer-1/builds/34210048

@stephiescastle stephiescastle requested review from jamesray and removed request for jamesray May 14, 2024 17:38
@stephiescastle stephiescastle marked this pull request as ready for review May 14, 2024 20:28
@stephiescastle
Copy link
Member Author

@jamesray This is now ready for review. I'd like to get these changes in before converting explorer-1 to a monorepo.

Copy link
Member

@jamesray jamesray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this trigger a 1.11.0 release?

@stephiescastle
Copy link
Member Author

@jamesray I'll set up a releaase after merge. I bump the major version since it will change from Tailwind 2 to 3.

@stephiescastle stephiescastle merged commit cf42e23 into main May 15, 2024
1 check passed
@stephiescastle stephiescastle deleted the chore/upgrade-storybook-tailwind branch May 15, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance The meta work of maintaining the project major Contains breaking changes from previous release storybook This issue relates to Storybook.js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants