-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade to Storybook 8, Tailwind 3, and npm v20+ #428
Conversation
- recreate theme selection capability - fix react component renderer - use dynamic descriptions - convert mdx - fix links within stories - fix js mounting restoring designlab branding theme Restoring markdown in Description
- clean up and restoring html viewer - cleaning up docs in storybook - fixing percy integration
Link to visual regression test: https://percy.io/e5a03e0a/explorer-1/builds/34210048 |
@jamesray This is now ready for review. I'd like to get these changes in before converting explorer-1 to a monorepo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this trigger a 1.11.0 release?
@jamesray I'll set up a releaase after merge. I bump the major version since it will change from Tailwind 2 to 3. |
Checklist
Description
This work is the first step in prepping Explorer-1 for EDU development: https://github.com/nasa-jpl/www/issues/10
Instructions to test
nvm install 20.13.1
nvm use
npm i
npm run build
npm run storybook
Tested in the following environments/browsers:
Operating System
Browser