Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add theming capability to Explorer 1 #433

Merged
merged 40 commits into from
May 24, 2024
Merged

Add theming capability to Explorer 1 #433

merged 40 commits into from
May 24, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented May 23, 2024 •
edited
Loading

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Adds Tailwindcss themer and introduces a few semantic color aliases per https://github.com/nasa-jpl/www/issues/19#issuecomment-2125971990

Fixes https://github.com/nasa-jpl/www/issues/19

Instructions to test

You must have pnpm installed.

  1. make install
  2. make vue
  3. View http://localhost:5173/
  4. Edit /packages/vue/index.html and change <html data-theme="defaultTheme"> to <html data-theme="edu">
  5. Save and check the browser. You should now see edu colors.

Added May 23, 2024: you can also test using the theme switcher in Storybook.

  1. make install
  2. make vue-storybook
  3. View BaseButton, and switch the theme to EDU. Note that the dark and light variants aren't completed yet.

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle
converting monorepo (pnpm workspaces)
dac0484
@stephiescastle
fixing symlinks issue in mdx
91f7f12
@stephiescastle
fixing ts config in packages/html
2067fd6
@stephiescastle
small fixes to tailwind config and mdx render
33b8602
@stephiescastle
unifying prettier config and tsconfig
5f69fd6
@stephiescastle
prototyping how to share story data between storybooks
4902c42
@stephiescastle
completing @explorer-1/vue package
cf454c5
@stephiescastle
completing @explorer-1/storybook-vue app
8abac70
@stephiescastle
updating makefile
0ffed09
@stephiescastle
switching vue vite to library mode
71cfbbd
@stephiescastle
adding @explorer-1/nuxt module
857f94d
@stephiescastle
adding module to makeful, minor cleanup
0091991
@stephiescastle
fixing duplicate modules in vite
6548a8e
@stephiescastle
fixing make commands, building module
a74fa2f
@stephiescastle
removing ignored dist
1c2c475
@stephiescastle
updating gitignore
ef6df67
@stephiescastle
renaming storybook-* to *-storybook
eb1f8fb
@stephiescastle
updating Storybook to 8.1.2
5e0196d
@stephiescastle
wip updating github workflow for pnpm
0107fef
@stephiescastle
Adding scaffolding for theming Explorer-1
81ef970 
converting a few more simple components for testing

basic theming scaffolding in place
@stephiescastle stephiescastle changed the base branch from main to feature/monorepo May 23, 2024 00:24
@github-actions github-actions bot added the maintenance The meta work of maintaining the project label May 23, 2024
@stephiescastle
Improvements to Storybook theme switcher
4ab62c4 
- Properly support theme and variant
- Adding to @explorer-1/vue-storybook

properly support theme and variant in storybook
@stephiescastle stephiescastle marked this pull request as draft May 23, 2024 17:47
@stephiescastle stephiescastle added feature major Contains breaking changes from previous release labels May 23, 2024
@stephiescastle stephiescastle removed the maintenance The meta work of maintaining the project label May 23, 2024
@jamesray
Copy link
Member

Good start!

Base automatically changed from feature/monorepo to main May 24, 2024 18:43
@stephiescastle stephiescastle changed the title Proof of concept: Explorer 1 themes Add theming capability to Explorer 1 May 24, 2024
@stephiescastle stephiescastle marked this pull request as ready for review May 24, 2024 19:02
@stephiescastle stephiescastle merged commit 970e171 into main May 24, 2024
1 check passed
@stephiescastle stephiescastle deleted the poc/edu-theme branch May 24, 2024 19:13
@stephiescastle stephiescastle mentioned this pull request May 30, 2024
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesray jamesray jamesray approved these changes

@thibaudcolas thibaudcolas Awaiting requested review from thibaudcolas

Assignees
No one assigned
Labels
feature major Contains breaking changes from previous release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephiescastle @jamesray