Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Co-locate vue storybook stories with components #470

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Jun 26, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Fixes #463

Moves vue stories to the vue packages. Keeping them separated was making the development process less intuitive, and also leading to potential infinite imports (circular dependencies).

Also prepares for CI checks, as this removes relative paths to other parts of the monorepo from dependencies.

Instructions to test

  1. make vue-storybook
  2. huzzah!

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle stephiescastle added patch Contains bug fixes or maintenance work developer experience Making it easier for developers to contribute maintenance The meta work of maintaining the project labels Jun 26, 2024
@github-actions github-actions bot added the storybook This issue relates to Storybook.js label Jun 26, 2024
@stephiescastle stephiescastle merged commit 01e9f83 into main Jun 26, 2024
1 check passed
@stephiescastle stephiescastle deleted the refactor/storybook-story-locations branch June 26, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience Making it easier for developers to contribute maintenance The meta work of maintaining the project patch Contains bug fixes or maintenance work storybook This issue relates to Storybook.js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Co-locate css and story files with vue components
2 participants