Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI checks #484

Merged
merged 28 commits into from
Jul 11, 2024
Merged

CI checks #484

merged 28 commits into from
Jul 11, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Jul 8, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

https://github.com/nasa-jpl/www/issues/81

Adds CI tests for:

  • vue build smoke test
  • storybook component smoke tests
  • storybook component accessibility tests
  • publishes to chromatic

Fixes previously failing accessibility tests.

Instructions to test

View the actions in this PR

@github-actions github-actions bot added feature maintenance The meta work of maintaining the project labels Jul 8, 2024
@stephiescastle stephiescastle marked this pull request as draft July 8, 2024 20:40
@stephiescastle stephiescastle marked this pull request as ready for review July 10, 2024 22:39
@stephiescastle stephiescastle changed the title WIP: CI checks CI checks Jul 11, 2024
@stephiescastle stephiescastle merged commit c0110fa into main Jul 11, 2024
6 of 7 checks passed
@stephiescastle stephiescastle deleted the feature/ci-checks branch July 11, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature maintenance The meta work of maintaining the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants