Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/Revert #479 #489

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix/Revert #479 #489

merged 1 commit into from
Jul 11, 2024

Conversation

stephiescastle
Copy link
Member

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Reverts #479. When testing with WWW, I was running into errors. I also referenced this discussion thread:
vitest-dev/vitest#2484

Instructions to test

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle stephiescastle marked this pull request as draft July 11, 2024 16:16
@stephiescastle stephiescastle marked this pull request as ready for review July 11, 2024 16:33
@jamesray jamesray self-requested a review July 11, 2024 16:59
@stephiescastle stephiescastle added patch Contains bug fixes or maintenance work bug Something isn't working labels Jul 11, 2024
@stephiescastle stephiescastle changed the title Revert #479 fix/Revert #479 Jul 11, 2024
@stephiescastle stephiescastle merged commit 64acaa6 into main Jul 11, 2024
7 of 8 checks passed
@stephiescastle stephiescastle deleted the revert/479-dayjs branch July 11, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Contains bug fixes or maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants