Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consolidate components and docs into one Storybook #494

Merged
merged 15 commits into from
Jul 16, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Jul 16, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

  • Fixes https://github.com/nasa-jpl/www/issues/21
  • Adds form components from the html to the vue and updates FormContact and FormNewsletter to use them
  • Adds documentation and overview pages from html Storybook to vue

Instructions to test

  1. make storybook
  2. browse at http://localhost:6006

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@github-actions github-actions bot added the maintenance The meta work of maintaining the project label Jul 16, 2024
@stephiescastle stephiescastle changed the title Chore/21 consolidate www frontend chore: consolidate components and docs into one Storybook Jul 16, 2024
@stephiescastle stephiescastle added the storybook This issue relates to Storybook.js label Jul 16, 2024
@stephiescastle stephiescastle merged commit 3d8cc33 into main Jul 16, 2024
6 of 7 checks passed
@stephiescastle stephiescastle deleted the chore/21-consolidate-www-frontend branch July 16, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance The meta work of maintaining the project storybook This issue relates to Storybook.js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants