Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clarifying story names for hero components #495

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Jul 17, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Cleans up story names for hero components in Storybook.

Instructions to test

  1. make vue-storybook
  2. View this section: http://localhost:6006/?path=/docs/components-heroes-overview--docs

OR view this directly on chromatic: https://668c47cbeb95392cd79c3c0d-iayokidrgk.chromatic.com/?path=/docs/components-heroes-overview--docs

@stephiescastle stephiescastle added storybook This issue relates to Storybook.js patch Contains bug fixes or maintenance work labels Jul 17, 2024
@github-actions github-actions bot added the maintenance The meta work of maintaining the project label Jul 17, 2024
@stephiescastle stephiescastle merged commit f23fbbb into main Jul 17, 2024
6 checks passed
@stephiescastle stephiescastle deleted the chore/clarifying-story-names branch July 17, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance The meta work of maintaining the project patch Contains bug fixes or maintenance work storybook This issue relates to Storybook.js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants