Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove default size from BaseHeading #504

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix: remove default size from BaseHeading #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vue/src/components/BaseHeading/BaseHeading.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default defineComponent({
size: {
type: String as PropType<HeadingLevel>,
required: false,
default: 'h2',
default: '',
validator: (prop: string): boolean => Object.keys(headings).includes(prop)
}
},
Expand Down
1 change: 0 additions & 1 deletion packages/vue/src/components/BlockHeading/BlockHeading.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<BaseHeading
v-if="data"
:level="data.level"
:size="data.size"
>
{{ data.heading }}
</BaseHeading>
Expand Down
10 changes: 10 additions & 0 deletions packages/vue/src/components/BlockStreamfield/BlockStreamfield.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,16 @@ export const BlockStreamfieldData = {
'<p>Lorem ipsum <a href="/missions/test-mission/">dolor</a> sit amet, consectetur adipiscing elit. Quisque vitae justo quis justo malesuada molestie. Cras sed tincidunt dui.</p><p>Integer imperdiet blandit neque vitae euismod. Nulla aliquet lacus nibh, vel tincidunt urna efficitur non. In et eros vitae ex posuere maximus quis eget urna. Suspendisse fringilla posuere velit sit amet posuere. Morbi malesuada bibendum vehicula. Donec faucibus ut erat ut mattis. Suspendisse ornare, quam at placerat cursus, dolor mi lacinia nunc, eget maximus augue nulla in dolor.</p>\n'
},
BlockInlineImageData.block,
{
blockType: 'HeadingBlock',
heading: 'Heading 2',
level: 'h2'
},
{
blockType: 'HeadingBlock',
heading: 'Heading 3',
level: 'h3'
},
{
blockType: 'RichTextBlock',
value:
Expand Down
Loading