Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: integrating all page templates from www-frontend #510

Merged
merged 11 commits into from
Jul 22, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Jul 20, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Fixes #509
Fixes https://github.com/nasa-jpl/www/issues/220

  • Also uses a darker shade of jpl red for subtitles that were on gray backgrounds in HomepageStats

Instructions to test

  1. make vue-storybook
  2. browse the "Templates" section

Or view on chromatic: https://668c47cbeb95392cd79c3c0d-ycicumnukd.chromatic.com/?path=/story/templates-www-pageasteroidwatchcontent--base-story

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle stephiescastle added patch Contains bug fixes or maintenance work feature parity Work needed to maintain consistency between our implementations of Explorer 1 labels Jul 20, 2024
@github-actions github-actions bot added the maintenance The meta work of maintaining the project label Jul 20, 2024
@stephiescastle stephiescastle marked this pull request as draft July 20, 2024 01:07
@stephiescastle stephiescastle marked this pull request as ready for review July 22, 2024 19:42
@stephiescastle stephiescastle merged commit 58ae058 into main Jul 22, 2024
5 checks passed
@stephiescastle stephiescastle deleted the chore/www-page-templates branch July 22, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature parity Work needed to maintain consistency between our implementations of Explorer 1 maintenance The meta work of maintaining the project patch Contains bug fixes or maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3: migrate www-frontend page templates to explorer-1
2 participants