-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: font organization #523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question borne of my ignorance about the new multi-package structure: As the HTML and Vue packages are now including styles-with-fonts, how does a consumer opt to use styles(-without-fonts)? I gather that the docs for this revamp are still a WIP, but we'll definitely want to remember to explain this there later.
It depends on how the user wants to optimize their fonts. For us, we are going with @nuxt/fonts, which we will likely add docs on how to use. Nuxt-less, users can optimize fonts the way we did originally in www-frontend (load the _fonts.scss file as css on the frontend). We can include a way to generate a 'font-face.css' from the scss file in the docs, but I don't think it's urgent now. I created a stub issue for this, though really we need a stub issue for docs overhaul. |
…on bump in monorepo version number
Checklist
Description
MixinCarousel
to not allow clicking on slides that are "out of view" (partially visible or transparent) as it was failing accessibility tests in some instances.Note: I did consider making the default styles.scss include fonts and creating a separate file that excludes them, but the way I've done it in this PR is the most efficient code-wise.
Breaking Changes
styles.scss
will need to now import fonts separately or usestyles-with-fonts.scss
insteadInstructions to test
Tested in the following environments/browsers:
Operating System
Browser