Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: percy visual regression tests #526

Merged
merged 4 commits into from
Jul 30, 2024
Merged

chore: percy visual regression tests #526

merged 4 commits into from
Jul 30, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Jul 30, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Completes https://github.com/nasa-jpl/www/issues/188

  • Removes Chromatic visual regression tests (no quota) and adds percy visual regression tests to our CI.
  • Check /apps/vue-storybook/.percy.yml to see a list of included/excluded stories. We may continue to refine this depending on how our quota usage goes.

Instructions to test

  1. pnpm install
  2. make vue-storybook-build
  3. pnpm --filter @explorer-1/vue-storybook percy:dry-run

@stephiescastle stephiescastle added patch Contains bug fixes or maintenance work maintenance The meta work of maintaining the project labels Jul 30, 2024
@stephiescastle
Copy link
Member Author

stephiescastle commented Jul 30, 2024

Link to percy tests: https://percy.io/e5a03e0a/explorer-1/builds/35608683

Note: this generated 1434 snapshots and used ~5% of our quota. Seems a bit high, so I might remove firefox snapshots since @Scotchester and I regularly use the site in Firefox. I think we need to keep Safari snapshots, though. This should reduce snapshots by a third.

@stephiescastle
Copy link
Member Author

Note, I canceled the last test action to not needlessly use up our quota.

@stephiescastle stephiescastle merged commit 43fe85f into main Jul 30, 2024
1 of 5 checks passed
@stephiescastle stephiescastle deleted the chore/percy branch July 30, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance The meta work of maintaining the project patch Contains bug fixes or maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants