Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: listing metadata #541

Merged
merged 15 commits into from
Aug 14, 2024
Merged

feature: listing metadata #541

merged 15 commits into from
Aug 14, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Aug 13, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Addresses #191

  • Renames BaseTag to BasePill and modifies it to automatically determine label and variant depending on content type
  • Adds CalendarChip component (the square that overlays images) and modifies existing components to use it
  • Adds MetadataEvent and MetadataEduResource components to render bits of metadata alongside icons
  • Modifies all event-related components that show metadata to use MetadataEvent
  • Modifies HeroListingPage to use the modified BasePill component
  • Modifies BlockLinkCard to use the components above to render EDU cards as specified by the designs
  • Modifies SearchResultsCard and SearchResultsGridItem to use EDU-specific cards
  • Modifies DetailHeadline to match pill/label strategy in designs
  • Adds story for SearchResultsList

Instructions to test

  1. make vue-storybook
  2. http://localhost:6006/?path=/story/components-cards-blocklinkcard--event-item&globals=theme:ThemeEdu
  3. http://localhost:6006/?path=/story/components-cards-searchresultcards--edu-event-card&globals=theme:ThemeEdu
  4. http://localhost:6006/?path=/story/components-cards-blocklinkcard--large-edu-explainer-article&globals=theme:ThemeEdu
  5. http://localhost:6006/?path=/story/components-heroes-for-listing-pages--base-story&globals=theme:ThemeEdu

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle stephiescastle added the patch Contains bug fixes or maintenance work label Aug 13, 2024
Copy link
Member

@jamesray jamesray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@stephiescastle stephiescastle merged commit 6ca65fa into main Aug 14, 2024
7 checks passed
@stephiescastle stephiescastle deleted the feature/191-listing-metadata branch August 14, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature patch Contains bug fixes or maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants