-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: GitHub gist embed block #547
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesray would you be able to address the accessibility issue? You can determine the exact issue by opening storybook, going to the BlockGist story, then viewing the accessibility tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more note: the block also needs to be added to BlockStreamfield
Thank you!
Changes requested are done. integrated into frontend at nasa-jpl/www #385 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesray Looks good to me. I can't recreate the failing accessibility test that CI found.
Mind updating this with latest main? Then we'll let actions run again and see what happens.
@stephiescastle passed, I can remerge in the other changes to main tho |
Checklist
Description
gist block, embed gists with just a URL and caption (links to github source)
Instructions to test
make vue-storybook
see the blockGist story hereTested in the following environments/browsers:
Operating System
Browser