Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: GitHub gist embed block #547

Merged
merged 7 commits into from
Aug 19, 2024
Merged

feature: GitHub gist embed block #547

merged 7 commits into from
Aug 19, 2024

Conversation

jamesray
Copy link
Member

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

gist block, embed gists with just a URL and caption (links to github source)

Instructions to test

make vue-storybook see the blockGist story here

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@jamesray jamesray added feature request Request to add a new component or other feature feature labels Aug 16, 2024
@jamesray
Copy link
Member Author

Copy link
Member

@stephiescastle stephiescastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesray would you be able to address the accessibility issue? You can determine the exact issue by opening storybook, going to the BlockGist story, then viewing the accessibility tab.

Copy link
Member

@stephiescastle stephiescastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more note: the block also needs to be added to BlockStreamfield

Thank you!

@jamesray
Copy link
Member Author

Changes requested are done. integrated into frontend at nasa-jpl/www #385

Copy link
Member

@stephiescastle stephiescastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesray Looks good to me. I can't recreate the failing accessibility test that CI found.

Mind updating this with latest main? Then we'll let actions run again and see what happens.

@jamesray
Copy link
Member Author

@stephiescastle passed, I can remerge in the other changes to main tho

@jamesray jamesray merged commit f3798eb into main Aug 19, 2024
7 checks passed
@jamesray jamesray deleted the feat/173-gist-block branch August 19, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request to add a new component or other feature feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants