Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing feedback on Teachable Moments template #575

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Fixing feedback on Teachable Moments template #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d3e671
fixing jump menu links in mobile menu, adding readtime to teachable m…
stephiescastle Aug 27, 2024
aafe069
Merge branch 'main' into qa/teachable-moments
stephiescastle Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vue/src/components/AboutTheAuthor/AboutTheAuthor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const headingString = computed(() => {
</script>
<template>
<div class="AboutTheAuthor">
<h3 class="text-h4 sm:ml-[130px] pl-10 mb-6">
<h3 class="text-h4 sm:ml-[130px] sm:pl-10 mb-6">
{{ headingString }}
</h3>
<template
Expand Down
1 change: 1 addition & 0 deletions packages/vue/src/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ export interface PageObject {
slug: string
url: string
title: string
readTime?: string
getTopicsForDisplay?: Topic[]
showJumpMenu?: boolean
label?: string
Expand Down
2 changes: 1 addition & 1 deletion packages/vue/src/templates/edu/PageEduCollectionsDetail/PageEduCollectionsDetail.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ const computedClass = computed((): string => {
/>

<NavJumpMenu
v-if="data.showJumpMenu"
ref="PageEduCollectionsDetailJumpMenu"
:title="data.title"
:blocks="data.body"
:enabled="data.showJumpMenu"
dropdown-text="In this collection"
/>

Expand Down
2 changes: 1 addition & 1 deletion packages/vue/src/templates/edu/PageEduExplainerArticle/PageEduExplainerArticle.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,9 @@ export default defineComponent({
</LayoutHelper>

<NavJumpMenu
v-if="data.showJumpMenu"
:title="data.title"
:blocks="data.body"
:enabled="data.showJumpMenu"
dropdown-text="In this article"
/>
<!-- inline hero content -->
Expand Down
1 change: 0 additions & 1 deletion packages/vue/src/templates/edu/PageEduLesson/PageEduLesson.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,6 @@ const consolidatedSections = computed((): EduLessonSectionObject[] => {
ref="PageEduLessonJumpMenu"
:title="data.title"
:blocks="consolidatedBlocks"
:enabled="true"
dropdown-text="In this lesson"
/>

Expand Down
2 changes: 1 addition & 1 deletion packages/vue/src/templates/edu/PageEduNewsDetail/PageEduNewsDetail.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,10 @@ defineExpose({
itemtype="http://schema.org/Article"
>
<NavJumpMenu
v-if="data.showJumpMenu"
ref="PageEduNewsDetailJumpMenu"
:title="data.title"
:blocks="data.body"
:enabled="data.showJumpMenu"
dropdown-text="In this news article"
/>

Expand Down
1 change: 1 addition & 0 deletions packages/vue/src/templates/edu/PageEduTeachableMoment/PageEduTeachableMoment.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export const BaseStory = {
url: 'http://localhost:3000/edu/resources/teachable-moment',
pageType: 'EDUTeachableMomentPage',
contentType: 'edu_resources.EDUTeachableMomentPage',
readTime: '5 min read',
showJumpMenu: true,
thumbnailImage: {
__typename: 'CustomImage',
Expand Down
3 changes: 2 additions & 1 deletion packages/vue/src/templates/edu/PageEduTeachableMoment/PageEduTeachableMoment.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,10 @@ const computedClass = computed((): string => {
:class="computedClass"
>
<NavJumpMenu
v-if="data.showJumpMenu"
ref="PageEduTeachableMomentJumpMenu"
:title="data.title"
:blocks="data.body"
:enabled="data.showJumpMenu"
dropdown-text="In this Teachable Moment"
/>

Expand All @@ -97,6 +97,7 @@ const computedClass = computed((): string => {
>
<DetailHeadline
:title="data.title"
:read-time="data.readTime"
label="Teachable Moment"
pill
/>
Expand Down
Loading