Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: anchor links in mobile nav, long menus in Jump Nav #626

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Sep 19, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Addresses feedback:

Changes:

  • differentiates between router and regular links in NavSecondary (this was breaking the anchor links because everything was being rendered as a router link)
  • adds a max height and overflow-y-auto to NavJumpMenu items.

Instructions to test

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle stephiescastle added bug Something isn't working patch Contains bug fixes or maintenance work labels Sep 19, 2024
@stephiescastle stephiescastle changed the title fix: anchor links in mobile nav fix: anchor links in mobile nav, long menus in Jump Nav Sep 19, 2024
@stephiescastle stephiescastle merged commit 556fd23 into main Sep 20, 2024
6 checks passed
@stephiescastle stephiescastle deleted the fix/jump-menus branch September 20, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Contains bug fixes or maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants