Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/edu collections block link card #634

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Sep 24, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Addresses feedback:

Changes:

  • Adds a nested component to BlockLinkCard that will only be in visible in search results for EDU Collections
  • Styles include both list and grid search result layouts

Instructions to test

Check chromatic:

  1. List results: https://668c47cbeb95392cd79c3c0d-sxdljonzmd.chromatic.com/?path=/story/components-cards-blocklinkcard--edu-collection-large&globals=theme:ThemeEdu
  2. Grid results: https://668c47cbeb95392cd79c3c0d-sxdljonzmd.chromatic.com/?path=/story/components-cards-blocklinkcard--edu-collection&globals=theme:ThemeEdu

Or test locally:

  1. make vue-storybook
  2. List results: http://localhost:6006/?path=/story/components-cards-blocklinkcard--edu-collection-large&globals=theme:ThemeEdu
  3. Grid results: http://localhost:6006/?path=/story/components-cards-blocklinkcard--edu-collection&globals=theme:ThemeEdu

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

Copy link
Member

@Scotchester Scotchester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in my local Storybook. I do have a bitpicky question about the naming of "special styles", though – Could it be more descriptive? Maybe something like "show listing styles", along the lines of the existing "show calendar chip"?

@stephiescastle
Copy link
Member Author

"show listing styles"

Yeah, this was tricky for me to name. The thing is that the combination of all of the props is essentially the listing styles. Collections has like a super featured style. Maybe I'll make it useFeaturedStyles ?

@stephiescastle stephiescastle merged commit 2e59d34 into main Sep 24, 2024
6 checks passed
@stephiescastle stephiescastle deleted the feature/edu-collections-block-link-card branch September 24, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants