Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: full bleed adjustments #637

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

stephiescastle
Copy link
Member

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Addresses feedback:

Changes:

  • EDU NavDesktop will now expand to full-width
  • Removed gray extenders in HeroMedia and BlockImageFullBleed site-wide
  • Modified BlockCardGrid to only expand to four columns if there are at least four cards. I also changed the breakpoint for when this expands, as it's previous breakpoint didn't make much sense (its container wasn't changing size, just the viewport).

Instructions to test

  1. make vue-storybook
  2. Full width EDU Nav: http://localhost:6006/?path=/story/navigation-headers-edu-navdesktopedu--base-story&globals=theme:ThemeEdu
  3. Remove gray extenders:
  4. BlockCardGrid

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle stephiescastle added the patch Contains bug fixes or maintenance work label Sep 25, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 25, 2024
@@ -12,7 +12,7 @@
}"
>
<!-- navbar -->
<div class="header-bg z-10 max-w-screen-3xl absolute inset-0 mx-auto"></div>
<div class="header-bg z-10 absolute inset-0 mx-auto"></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think this class also needs to be removed from the beta banner.
  2. Any reason to not also remove it from the WWW desktop nav?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Yes, plan to do that in www PR that also updates the explorer-1 version
  2. Yes, due to the nature of the nav sometimes being transparent with a gradient, and sometimes solid white.

Comment on lines +95 to +97
export const ThreeCards = {
args: { cards: BlockCardGridData.slice(0, 3) }
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's a new story to cover the use-case when there are only 3 cards

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing that merely adding those three lines adds a whole story 🪄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storybook has gotten much more streamlined!

@stephiescastle stephiescastle merged commit d671d74 into main Sep 25, 2024
7 checks passed
@stephiescastle stephiescastle deleted the fix/full-bleed-adjustments branch September 25, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Contains bug fixes or maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants