-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: full bleed adjustments #637
Conversation
@@ -12,7 +12,7 @@ | |||
}" | |||
> | |||
<!-- navbar --> | |||
<div class="header-bg z-10 max-w-screen-3xl absolute inset-0 mx-auto"></div> | |||
<div class="header-bg z-10 absolute inset-0 mx-auto"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think this class also needs to be removed from the beta banner.
- Any reason to not also remove it from the WWW desktop nav?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Yes, plan to do that in www PR that also updates the explorer-1 version
- Yes, due to the nature of the nav sometimes being transparent with a gradient, and sometimes solid white.
export const ThreeCards = { | ||
args: { cards: BlockCardGridData.slice(0, 3) } | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's a new story to cover the use-case when there are only 3 cards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing that merely adding those three lines adds a whole story 🪄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storybook has gotten much more streamlined!
Checklist
Description
Addresses feedback:
Changes:
HeroMedia
andBlockImageFullBleed
site-wideInstructions to test
make vue-storybook
Tested in the following environments/browsers:
Operating System
Browser