Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add support for secondary nav on EDU Collections template #650

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Oct 3, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Addresses feedback:

Changes

  • Adds support for secondary nav on the EDU Collections template
  • Adds additional stories to demonstrate the use-case with different hero configurations

Note: the following needs to be completed for the secondary nav to be used in the CMS

Instructions to test

  1. make vue-storybook
  2. View stories that pair secondary nav with:

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle
Copy link
Member Author

stephiescastle commented Oct 3, 2024

Note that https://github.com/nasa-jpl/www/issues/616 will need to be completed for the secondary nav to actually be used in the CMS

@stephiescastle stephiescastle merged commit 848bde5 into main Oct 7, 2024
6 checks passed
@stephiescastle stephiescastle deleted the feature/secondary-nav-edu-collections branch October 7, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants