Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding trailing slashes in BaseLink #661

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Oct 12, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Supports:

Adds a trailing slash to all links regardless if it's a router link or not. Checks urls for files and query params.

Instructions to test

Not testable in Storybook as we use a mock component for NuxtLink. Best way to test is in www. To do this locally:

  1. in www, replaced the @explorer-1 packages in /apps/frontend/package.json with the paths in /README.md
  2. pnpm i
  3. make frontend-local

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@github-actions github-actions bot added the bug Something isn't working label Oct 12, 2024
Copy link
Member

@Scotchester Scotchester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing trailing slashes on listing links now!

@stephiescastle stephiescastle merged commit 45cc30f into main Oct 12, 2024
7 checks passed
@stephiescastle stephiescastle deleted the fix/base-link-trailing-slash branch October 12, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants