Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/671 include richtext headings jump menu #671

Merged
merged 7 commits into from
Oct 23, 2024

Conversation

stephiescastle
Copy link
Member

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Addresses:

Changes:

  • Adds two new utility functions: anchorizeBlock and anchorizeStreamfield
  • Uses the new utils in nearly all EDU Resource templates to treat rich text headings as jump menu items
  • Exceptions: Did not do this change for EDU Student Projects or EDU Galleries, as both of those templates have more strict definition of what the jump menu should be populated with (Step headings for the former, and Gallery item titles for the latter)

Instructions to test

View all EDU Resource templates. Check the jumpmenu for" Heading from richtext" (except on Galleries and Student Projects)

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle stephiescastle merged commit 7bca7e0 into main Oct 23, 2024
7 checks passed
@stephiescastle stephiescastle deleted the feature/671-include-richtext-headings-jump-menu branch October 23, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants