added multiline output keyword support; propogated ions into product …#52
Merged
markleader merged 1 commit intonasa:mainfrom Mar 2, 2026
Merged
added multiline output keyword support; propogated ions into product …#52markleader merged 1 commit intonasa:mainfrom
markleader merged 1 commit intonasa:mainfrom
Conversation
…mixture through legacy cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two legacy CLI compatibility issues affecting CEARUN-style inputs:
EqSolver_initelement-list mismatch crashes for ionized legacy problems by ensuring reactants/products are initialized with consistentionshandling.outputdatasets (multipleoutput ...lines in one problem).Changes
ions=prob%problem%include_ionsin:run_thermo_problem(source/main.f90)run_shock_problem(source/main.f90)run_deton_problem(source/main.f90)source/input.f90:outpdataset, consecutiveoutpkeyword lines are merged into the same buffer instead of starting a new dataset that overwrites prior output options.cea2.fbehavior for repeatedoutputdirectives.source/input_test.pf:test_parse_outp_repeated_dataset_keywordsoutptokens cumulatively setmass_fractions,transport,trace, and preservesiunit.Testing
build-dev-ub-hunt/source:./cea cearun -t ../../data/thermo.lib -r ../../data/trans.lib./cea example1 -t ../../data/thermo.lib -r ../../data/trans.libdiff -u cearun-ref.out cearun.out(verified crash is resolved and expected output sections are present; formatting/style differences remain vs legacy reference formatting)cd build-dev-ub-hunt && ctest --output-on-failure(12/12 passed)Compatibility / Numerical behavior
Expected behavior change: ionized legacy CLI cases that previously aborted with
CRITICAL: eqsolver_init: Element lists for products and reactants must match.now run to completion. No solver algorithm changes were introduced; updates are limited to initialization consistency and legacy-compatible
outputparsing.