Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBDAAC and SeaBASS Portal Addition #1683

Merged
merged 10 commits into from
Oct 18, 2023
Merged

Conversation

jacobtdawson
Copy link
Contributor

@jacobtdawson jacobtdawson commented Oct 16, 2023

Overview

What is the feature?

This PR adds two portals to EarthData-Search. One is for OB.DAAC and the other is for SeaBASS

What is the Solution?

This simply follows the portal creation guide here: https://wiki.earthdata.nasa.gov/display/EDSC/Portal+Creation+Guide in order to add the two portals mentioned above.
I did this in a series of commits because of internal discussions about how our portal should look/work; please squash these, I don't want to mess up your commit history!

What areas of the application does this impact?

The "portal" feature

Testing

I have tested this locally on an instance running on our internal OBDAAC servers. It appears to run without issue, and the portals follow the format laid out by the portal creation guide and are similar to the already-present portals.

Attachments

Here's an image of the two portals I've added:
image

Checklist

  • [NA] I have added automated tests that prove my fix is effective or that my feature works
  • [NA] New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • [NA] I have commented my code, particularly in hard-to-understand areas
  • [NA] I have made corresponding changes to the documentation
  • My changes generate no new warnings

@jacobtdawson jacobtdawson marked this pull request as ready for review October 17, 2023 13:21
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1683 (ded2190) into main (6b5a830) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1683      +/-   ##
==========================================
- Coverage   91.92%   91.92%   -0.01%     
==========================================
  Files         723      723              
  Lines       19334    19334              
  Branches     4537     4537              
==========================================
- Hits        17773    17772       -1     
- Misses       1426     1427       +1     
  Partials      135      135              

see 1 file with indirect coverage changes

portals/obdaac/config.json Outdated Show resolved Hide resolved
portals/obdaac/config.json Outdated Show resolved Hide resolved
@eudoroolivares2016
Copy link
Contributor

I think we'll just need to rebase this branch

@jacobtdawson
Copy link
Contributor Author

I think we'll just need to rebase this branch

Rebased, I didn't know that github had such a nice feature for that!

@eudoroolivares2016
Copy link
Contributor

thank you! I can squash and merge when there is another approval from a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants