-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBDAAC and SeaBASS Portal Addition #1683
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1683 +/- ##
==========================================
- Coverage 91.92% 91.92% -0.01%
==========================================
Files 723 723
Lines 19334 19334
Branches 4537 4537
==========================================
- Hits 17773 17772 -1
- Misses 1426 1427 +1
Partials 135 135 |
I think we'll just need to rebase this branch |
Rebased, I didn't know that github had such a nice feature for that! |
thank you! I can squash and merge when there is another approval from a maintainer |
eudoroolivares2016
approved these changes
Oct 17, 2023
trevorlang
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
This PR adds two portals to EarthData-Search. One is for OB.DAAC and the other is for SeaBASS
What is the Solution?
This simply follows the portal creation guide here: https://wiki.earthdata.nasa.gov/display/EDSC/Portal+Creation+Guide in order to add the two portals mentioned above.
I did this in a series of commits because of internal discussions about how our portal should look/work; please squash these, I don't want to mess up your commit history!
What areas of the application does this impact?
The "portal" feature
Testing
I have tested this locally on an instance running on our internal OBDAAC servers. It appears to run without issue, and the portals follow the format laid out by the portal creation guide and are similar to the already-present portals.
Attachments
Here's an image of the two portals I've added:
Checklist