EDSC-3909: Fix showing direct collection -> variable associations

[eudoroolivares2016]

Overview

What is the feature?

There was a user requested fix to showing the variables associated to the collection in a project utilizing Harmony or OpenDap services. In EDSC-3817 a change was made to include only variables associated to the services of a collection. Instead this ticket updates this business logic to show the variables associated directly to the collection unless there exists variables associated to a service of the collection.

What is the Solution?

Tweak business logic in modules for building the access method component

What areas of the application does this impact?

Access methods

Testing

Add a collection to your project which implements opendap and or harmony services. Ensure that on the variables page (select Edit Variables on the Configure data customization options) we get a view of all of the variables associated to that collection if there exists no services on that collection which have variable associations.

Secondly ensure that for a collection which does contain variables associated to the services those variables are instead shown

This query from gaphql

query ($params: CollectionsInput) {
  collections(params: $params) {
    items {
      conceptId
      variables {
        count
        items {
          name
          conceptId
        }
      }
      services {
        items {
          variables {
            count
            items {
              name
              conceptId
            }
          }
        }
      }
    }
  }
}

along with the concept-id as a parameter can be used to validate that the metadata for the collection does/does not have either type of association.

Attachments

Using C1996881146-POCLOUD in the production envs

Using C1200277763-E2E_18_4 in the SIT env

Checklist

• I have added automated tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

[codecov]

Codecov Report

Merging #1687 (8954f4f) into main (b9523c5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1687      +/-   ##
==========================================
+ Coverage   91.91%   91.93%   +0.01%     
==========================================
  Files         724      724              
  Lines       19339    19344       +5     
  Branches     4553     4540      -13     
==========================================
+ Hits        17776    17783       +7     
+ Misses       1427     1426       -1     
+ Partials      136      135       -1     

Files	Coverage Δ
...ic/src/js/util/accessMethods/buildAccessMethods.js	86.95% <100.00%> (+1.01%)	⬆️
static/src/js/util/accessMethods/getVariables.js	100.00% <ø> (ø)

... and 1 file with indirect coverage changes

[macrouch]

We aren't paying by the character here, spell out your variable names ;)

[macrouch]

If the service has no variables associated with it, does serviceAssociatedVariables come back as null or { count: 0, items: null }?

[macrouch]

The first test where you moved the variables to the collection level, it still needs to return something for variables because the graphql query is requesting that field. So updating that test to look correct should answer my question

[eudoroolivares2016]

It comes back as { count: 0, items: null } in the graphql response

Needs changes