Revise modeling and code gen for default string sizes#4673
Merged
LeStarch merged 35 commits intonasa:develfrom Feb 5, 2026
Merged
Revise modeling and code gen for default string sizes#4673LeStarch merged 35 commits intonasa:develfrom
LeStarch merged 35 commits intonasa:develfrom
Conversation
These bugs were exposed by work on FPP nasa#903
To conform to change in generated code
…ue-903-default-string-size
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jwest115
approved these changes
Feb 3, 2026
Collaborator
jwest115
left a comment
jwest115
left a comment
There was a problem hiding this comment.
Reviewed default string size change, looks good!
Collaborator
Author
|
I am merging devel into this PR now. |
LeStarch
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Submitted
Ref/DpDemo, restore string sizes to 80 instead of using the defaultFW_FIXED_LENGTH_STRING_SIZE, which is 256 in the standard configuration. The test depends on size 80.CcsdsTcFrameDetector.Notes