Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAS-2255: Update link pattern in the extract-release-notes file. #5

Conversation

flamingbear
Copy link
Member

Description

Quick fix for the release notes extraction script.

I thought the extraction was broken, but it wasn't you can see the release

https://github.com/nasa/harmony-SMAP-L2-gridding-service/releases/tag/0.0.1

That said, the extraction release script was including the markdown reference to the release (even if GitHub ignored it when creating the release). This just fixes that bug.

This is even less important, because that link pattern only matters on the first release, but when I inevitably come and steal this script for the next new service, I'd like it to work.

Jira Issue ID

DAS-2267

Local Test Steps

  1. checkout main and run the releast notes script from the root directory:
❯ ./bin/extract-release-notes.sh

You will see that the extracted code includes the link reference at the bottom

### Added

- Initial codebase that transforms SPL2SMP_E granules into NetCDF4-CF grids. [#1](https://github.com/nasa/harmony-SMAP-L2-gridding-service/pull/1)
- Code and configuration to wrap gridding logic into a Harmony Service [#3](https://github.com/nasa/harmony-SMAP-L2-gridding-service/pull/3 )
- GitHub actions CI configuration [#4](https://github.com/nasa/harmony-SMAP-L2-gridding-service/pull/4 )


[v0.0.1]: https://github.com/nasa/harmony-SMAP-L2-gridding-service/releases/tag/0.0.1

Checkout this branch and run it again:

❯ ./bin/extract-release-notes.sh

You should see that the code no longer includes the markdown reference.

### Added

- Initial codebase that transforms SPL2SMP_E granules into NetCDF4-CF grids. [#1](https://github.com/nasa/harmony-SMAP-L2-gridding-service/pull/1)
- Code and configuration to wrap gridding logic into a Harmony Service [#3](https://github.com/nasa/harmony-SMAP-L2-gridding-service/pull/3 )
- GitHub actions CI configuration [#4](https://github.com/nasa/harmony-SMAP-L2-gridding-service/pull/4 )

PR Acceptance Checklist

  • [N/A] Jira ticket acceptance criteria met.
  • [N/A] CHANGELOG.md updated to include high level summary of PR changes.
  • [N/A] docker/service_version.txt updated if publishing a release.
  • [N/A] Tests added/updated and passing.
  • [N/A] Documentation updated (if needed).

@flamingbear flamingbear changed the title DAS-2255: Upate link pattern in the extract-release-notes file. DAS-2255: Update link pattern in the extract-release-notes file. Dec 2, 2024
@flamingbear flamingbear force-pushed the mhs/DAS-2267/update-release-note-extraction branch 2 times, most recently from 47c638f to bfe8e9e Compare December 3, 2024 16:12
Copy link
Member

@owenlittlejohns owenlittlejohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is even less important, because that link pattern only matters on the first release, but when I inevitably come and steal this script for the next new service, I'd like it to work.

Ha, yeah, exactly this.

@flamingbear flamingbear merged commit 0418041 into nasa:main Dec 3, 2024
11 checks passed
@flamingbear flamingbear deleted the mhs/DAS-2267/update-release-note-extraction branch December 3, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants