Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS-524: adding line back in and testing #5

Merged
merged 7 commits into from
Jan 31, 2025
Merged

KMS-524: adding line back in and testing #5

merged 7 commits into from
Jan 31, 2025

Conversation

mandyparson
Copy link
Contributor

Overview

What is the feature?

Please summarize the feature or fix.

What is the Solution?

Summarize what you changed.

What areas of the application does this impact?

List impacted areas.

Testing

Reproduction steps

  • Environment for testing:
  • Collection to test with:
  1. Step 1
  2. Step 2...

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@mandyparson mandyparson requested a review from jonvel January 31, 2025 21:55
Copy link

@eed-earthdataci eed-earthdataci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to my untrained eyes.

@mandyparson mandyparson requested a review from macrouch January 31, 2025 21:56
@mandyparson mandyparson merged commit de9aef9 into main Jan 31, 2025
4 checks passed
@mandyparson mandyparson deleted the KMS-524 branch January 31, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants