-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ogma-cli
: Provide ability to preprocess properties via external command. Refs #197.
#198
Merged
ivanperez-keera
merged 8 commits into
nasa:develop
from
ivanperez-keera:develop-prefilters
Jan 15, 2025
Merged
ogma-cli
: Provide ability to preprocess properties via external command. Refs #197.
#198
ivanperez-keera
merged 8 commits into
nasa:develop
from
ivanperez-keera:develop-prefilters
Jan 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o parse properties. Refs nasa#197. There is a need in Ogma to make the frontend more versatile, and to extend it to support languages unknown to Ogma without users having to modify the code of Ogma itself. To that end, we want to empower users with the ability to use a custom command to transform individual properties into a format that Ogma understands, and have Ogma call that external command on demand. Because calling an external command will be an IO action, any auxiliary sub-parsers used by Ogma should be IO actions, rather than pure functions. This commit modifies the parser for JSON specifications so that it takes as argument an IO action to parse individual properties.
… properties. Refs nasa#197. There is a need in Ogma to make the frontend more versatile, and to extend it to support languages unknown to Ogma without users having to modify the code of Ogma itself. To that end, we want to empower users with the ability to use a custom command to transform individual properties into a format that Ogma understands, and have Ogma call that external command on demand. Prior commits have extended the JSON parser to use an external IO action to parse individual properties, rather than pure functions, which is suitable when those actions represent calls to external processes. This commit modifies the ROS and F' backends to wrap parser functions into IO actions, as required by the modified JSON specification parser.
… properties. Refs nasa#197. There is a need in Ogma to make the frontend more versatile, and to extend it to support languages unknown to Ogma without users having to modify the code of Ogma itself. To that end, we want to empower users with the ability to use a custom command to transform individual properties into a format that Ogma understands, and have Ogma call that external command on demand. Prior commits have extended the JSON parser to use an external IO action to parse individual properties, rather than pure functions, which is suitable when those actions represent calls to external processes. This commit modifies the standalone backend to take an auxiliary command that is used as the process name to call to parse individual properties.
…ommand. Refs nasa#197. There is a need in Ogma to make the frontend more versatile, and to extend it to support languages unknown to Ogma without users having to modify the code of Ogma itself. To that end, we want to empower users with the ability to use a custom command to transform individual properties into a format that Ogma understands, and have Ogma call that external command on demand. Prior commits have extended the standalone backend with the capability of taking an auxiliary command as argument and running it to transform individual properties. This commit modifies the tests for the standalone command to explicitly provide no extenal processor, indicating that the properties in the files tested are in a known format.
…nd. Refs nasa#197. There is a need in Ogma to make the frontend more versatile, and to extend it to support languages unknown to Ogma without users having to modify the code of Ogma itself. To that end, we want to empower users with the ability to use a custom command to transform individual properties into a format that Ogma understands, and have Ogma call that external command on demand. Prior commits have extended the standalone backend with the capability of taking an auxiliary command as argument and running it to transform individual properties. This commit exposes that new argument to the user in the CLI.
Change Manager: Verified that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend Ogma with the ability to preprocess properties by using a user-provided tool, as prescribed in the solution proposed for #197.