Fixing direct import of skeleton_app into latest cfs #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@astrogeco - please do share your thoughts on this PR. |
|
|
||
| CommandCode = CFE_SB_GetCmdCode(Msg); | ||
| CFE_MSG_GetFcnCode(&SBBufPtr->Msg, &CommandCode); |
There was a problem hiding this comment.
would be good to check the return value == CFE_SUCCESS
|
|
||
| uint16 ActualLength = CFE_SB_GetTotalMsgLength(Msg); | ||
| CFE_MSG_GetSize(MsgPtr, &ActualLength); |
There was a problem hiding this comment.
same comment, check return value in case the message is mangled
| CFE_SB_TimeStampMsg(&SKELETON_AppData.HkBuf.MsgHdr); | ||
| CFE_SB_SendMsg(&SKELETON_AppData.HkBuf.MsgHdr); | ||
| CFE_SB_TimeStampMsg(&SKELETON_AppData.HkBuf.TlmHeader.Msg); | ||
| CFE_SB_TransmitMsg(&SKELETON_AppData.HkBuf.TlmHeader.Msg, true); |
There was a problem hiding this comment.
as above, should check return code (I realize the old code did not check return codes on these either :D )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue as highlighted in Skeleton_app creation #5
I was able to replicate the issue in Linux and Raspbian
Fixed the files to align to the latest functions and structures of the CFE
This version of skeleton_app can be directly copied into the apps folder of CFS. It will not give any errors when the make command is run.
Also the MID of messages have been updated in "skeleton_app_msgids.h" to avoid conflict with the Message Ids of sample_app which comes with the CFS. There is a high chance that the developer trying to learn might have both sample_app and skeleton_app included. Hence its important to have non-conflicting ids.