Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update makefile to explicit version on build as well as deploy #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bdelcamp
Copy link

Not sure what build process you use, but the latest version is never explicitly version tagged. So when this is updated to 4.6, I can't version lock at 4.5.4. I couldn't raise an issue on the repo, so I created a pull request to see if you could just explicitly tag images. Thanks!!!

@dereckson
Copy link
Member

Issues -> That's because GitHub is a mirror of our repository hosted on a Phabricator instance -> issues can be seen at https://devcentral.nasqueron.org/tag/xmpp/ (with a part related to our own server deployment)

Release process -> it's configured as an automatic build on Docker Hub, reacting to tags, so what would be the most useful would be to push tags I guess, and it's a cool idea to use the Makefile for that, because it's often forgotten, let's add a git push origin --tags in release process.

Another idea -> we can also perhaps configure a Jenkins job (adding a Jenkinsfile to the repo) to "fix" tags when a commit reach master:

  1. check if tag defined in VERSION exists
  2. if not, create it to current commit and push it

That would avoid humans forgot that ;)

@dereckson
Copy link
Member

(side comment: I've pushed a 4.5.4 tags by the way, so you can now lock it)

@dereckson
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants