Implement IO#pid

natalie-lang · Jul 10, 2024 · 1188773 · 1188773
1 parent 2f1a977
commit 1188773
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/include/natalie/io_object.hpp b/include/natalie/io_object.hpp
@@ -80,6 +80,7 @@ class IoObject : public Object {
     bool is_nonblock(Env *) const;
     bool isatty(Env *) const;
     int lineno(Env *) const;
+    Value pid(Env *) const;
     static Value pipe(Env *, Value, Value, Block *, ClassObject *);
     static Value popen(Env *, Args, Block *, ClassObject *);
     int pos(Env *);

diff --git a/lib/natalie/compiler/binding_gen.rb b/lib/natalie/compiler/binding_gen.rb
@@ -912,6 +912,7 @@ def generate_name
 gen.binding('IO', 'lineno', 'IoObject', 'lineno', argc: 0, pass_env: true, pass_block: false, return_type: :int)
 gen.binding('IO', 'lineno=', 'IoObject', 'set_lineno', argc: 1, pass_env: true, pass_block: false, return_type: :Object)
 gen.binding('IO', 'path', 'IoObject', 'get_path', argc: 0, pass_env: false, pass_block: false, aliases: ['to_path'], return_type: :Object)
+gen.binding('IO', 'pid', 'IoObject', 'pid', argc: 0, pass_env: true, pass_block: false, return_type: :Object)
 gen.binding('IO', 'pos=', 'IoObject', 'set_pos', argc: 1, pass_env: true, pass_block: false, return_type: :int)
 gen.binding('IO', 'pread', 'IoObject', 'pread', argc: 2..3, pass_env: true, pass_block: false, return_type: :Object)
 gen.binding('IO', 'print', 'IoObject', 'print', argc: :any, pass_env: true, pass_block: false, return_type: :Object)

diff --git a/spec/core/io/close_spec.rb b/spec/core/io/close_spec.rb
@@ -92,15 +92,11 @@
   it "clears #pid" do
     io = IO.popen ruby_cmd('r = loop{puts "y"; 0} rescue 1; exit r'), 'r'
 
-    NATFIXME 'Implement IO#pid', exception: NoMethodError, message: "undefined method `pid' for an instance of IO" do
-      io.pid.should_not == 0
-    end
+    io.pid.should_not == 0
 
     io.close
 
-    NATFIXME 'Implement IO#pid', exception: SpecFailedException, message: "undefined method `pid' for an instance of IO" do
-      -> { io.pid }.should raise_error(IOError)
-    end
+    -> { io.pid }.should raise_error(IOError)
   end
 
   it "sets $?" do

diff --git a/src/io_object.cpp b/src/io_object.cpp
@@ -571,6 +571,13 @@ Value IoObject::get_path() const {
     return new StringObject { *m_path };
 }
 
+Value IoObject::pid(Env *env) const {
+    if (m_pid == -1)
+        return NilObject::the();
+    raise_if_closed(env);
+    return Value::integer(m_pid);
+}
+
 Value IoObject::pread(Env *env, Value count, Value offset, Value out_string) {
     raise_if_closed(env);
     if (!is_readable(m_fileno))