Skip to content

Commit

Permalink
Merge pull request #2296 from herwinw/string_append_natfixme
Browse files Browse the repository at this point in the history
Update NATFIXME block in String concat specs
  • Loading branch information
seven1m authored Nov 6, 2024
2 parents e370c22 + c6377b1 commit 7245f20
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions spec/core/string/shared/concat.rb
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,10 @@
end

describe "when self and the argument are in different ASCII-compatible encodings" do
# NATFIXME: Implement SHIFT_JIS
xit "uses self's encoding if both are ASCII-only" do
"abc".encode("UTF-8").send(@method, "123".encode("SHIFT_JIS")).encoding.should == Encoding::UTF_8
it "uses self's encoding if both are ASCII-only" do
NATFIXME "it uses self's encoding if both are ASCII-only", exception: SpecFailedException do
"abc".encode("UTF-8").send(@method, "123".encode("SHIFT_JIS")).encoding.should == Encoding::UTF_8
end
end

it "uses self's encoding if the argument is ASCII-only" do
Expand Down

0 comments on commit 7245f20

Please sign in to comment.