Merge pull request #2241 from herwinw/marshal_dump_singleton_class

natalie-lang · Sep 29, 2024 · a12e271 · a12e271
2 parents 6bc2160 + 962415e
commit a12e271
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/spec/core/marshal/dump_spec.rb b/spec/core/marshal/dump_spec.rb
@@ -231,9 +231,7 @@ def _dump(level)
     end
 
     it "raises TypeError with a singleton Class" do
-      NATFIXME 'raises TypeError with a singleton Class', exception: SpecFailedException do
-        -> { Marshal.dump(class << self; self end) }.should raise_error(TypeError)
-      end
+      -> { Marshal.dump(class << self; self end) }.should raise_error(TypeError)
     end
   end
 

diff --git a/src/marshal.rb b/src/marshal.rb
@@ -219,6 +219,7 @@ def write_hash(values)
     end
 
     def write_class(value)
+      raise TypeError, "singleton class can't be dumped" if value.singleton_class?
       write_char('c')
       write_string_bytes(value.name)
     end