Implement Proc#source_location #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It uses the data from the Env object. The issues within the NATFIXME blocks are actually issues of Env, not of this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this one in a local branch for a while, but it needed the changes of ruby/spec#1060 before we could really merge them
The line numbers are often a few lines off, but that is simply because it gets the wrong information from Env. These FIXMEs should probably be changed somewhere in the compiler itself.
Even if the line numbers are a bit off, it's still a really useful tool to debug some things.
Before anyone gets the idea of simply copy-pasting this code to
Method#source_location: this one does not get any line information, so it would just returnnil.