Refresh shared spec for Regexp.quote/Regexp.escape #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seven1m
approved these changes
Sep 19, 2024
This includes a spec for the escape of `$`, which means we can remove our local spec for this.
herwinw
force-pushed
the
spec_regexp_quote
branch
from
961682d
to
0b52875
Compare
|
Rebased to fix the MacOS issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a spec for the escape of
$, which means we can remove our local spec for this.This finishes the leftovers of #2222, which depended on an upstream merge in ruby/spec.