Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise a RegexpError if the \u{} escape is empty #2229

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

herwinw
Copy link
Member

@herwinw herwinw commented Sep 20, 2024

No description provided.

They now work with the self hosted compiler too.
@herwinw herwinw removed their assignment Oct 6, 2024
@herwinw herwinw marked this pull request as ready for review October 6, 2024 07:57
@herwinw herwinw changed the title Fixes to Regexp Unicode escape Raise a RegexpError if the \u{} escape is empty Oct 6, 2024
@herwinw
Copy link
Member Author

herwinw commented Oct 6, 2024

This one had a rewrite after the changes of #2249. The Natalie regexp test now works with the self hosted compiler too.

@seven1m seven1m merged commit bea0b50 into natalie-lang:master Oct 6, 2024
15 checks passed
@herwinw herwinw deleted the regexp_unicode_escape branch October 6, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants