Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an exception for Marshal.dump of a singleton class #2241

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Raise an exception for Marshal.dump of a singleton class #2241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions spec/core/marshal/dump_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,7 @@ def _dump(level)
end

it "raises TypeError with a singleton Class" do
NATFIXME 'raises TypeError with a singleton Class', exception: SpecFailedException do
-> { Marshal.dump(class << self; self end) }.should raise_error(TypeError)
end
-> { Marshal.dump(class << self; self end) }.should raise_error(TypeError)
end
end

Expand Down
1 change: 1 addition & 0 deletions src/marshal.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ def write_hash(values)
end

def write_class(value)
raise TypeError, "singleton class can't be dumped" if value.singleton_class?
write_char('c')
write_string_bytes(value.name)
end
Expand Down
Loading