-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add devbox config #2274
Closed
Add devbox config #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herwinw
reviewed
Oct 27, 2024
In my devbox environment, this is failing. Need to figure out why...
I learned that libcrypt is deprecated, and libxcrypt is a suitable replacement. Yet, libxcrypt has certain unsecure algorithms disabled, which we need to pass ruby specs. Rather than using libcrypt or libxcrypt, let's copy over the crypt.h and crypt.c from Ruby.
I'm closing this agian. There were two issues:
There is some good work in this PR that I plan to ship as separate PRs, just without the devbox config. |
This was referenced Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using Devbox for some other projects and I wanted to see if using it here could simplify the setup process for new devs.
TODO: there are few failing specs (when run within a devbox shell) I need to figure out.
::crypt()
givesEINVAL
spec/core/file/flock_spec.rb
segfaultspec/core/io/write_spec.rb
Errno::ENOENT