Support fixed string argument with instance_eval #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herwinw
force-pushed
the
instance_eval_fixed_strings
branch
2 times, most recently
from
b04b86b
to
599d978
Compare
herwinw
force-pushed
the
instance_eval_fixed_strings
branch
3 times, most recently
from
93d64bb
to
1ac6004
Compare
Extract methods to handle compile time strings. We can reuse these for instance_eval.
This is a compile time macro, similar to eval.
herwinw
force-pushed
the
instance_eval_fixed_strings
branch
from
3ca9d0e
to
cb2ddcd
Compare
This is just the same macro code, called from a different location. This needs an extra check to ensure we operate on a compile time macro.
herwinw
force-pushed
the
instance_eval_fixed_strings
branch
from
cb2ddcd
to
9754b91
Compare
|
Moved the code to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking as draft for now, the code works but I'm not that satisfied with how it looks.
Transform instance_eval with a fixed string into a block at compile time, similar to the eval macro handling.