Make Args const in a couple of places #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This otherwise copy-constructs on many calls which calls malloc and so on and that's not good for function call performance. Side by side of fib(25) callgrind instructions: Before: summary: 2554791411 After: summary: 2167984106 Or about 15% faster.
|
This is fantastic. Thanks so much. 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This otherwise copy-constructs on many calls which calls malloc and so
on and that's not good for function call performance.
Side by side of fib(25) callgrind instructions:
Before:
summary: 2554791411
After:
summary: 2167984106
Or about 15% faster.