Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Likes cpmponent cleanup #36

Merged
merged 7 commits into from
Sep 4, 2024
Merged

Likes cpmponent cleanup #36

merged 7 commits into from
Sep 4, 2024

Conversation

vicliu2001
Copy link
Collaborator

Description

refactored likes component code

  • added contants.ts for client
  • removed unnecessary files and code

Documentation Used

Please list any documentation or resources that were referenced while making these changes.

  • Documentation A
  • Documentation B

Issues Faced and Resolutions

Please describe any issues you encountered during development and how you resolved them.

  • Issue: Description of the issue
    • Resolution: Steps taken to resolve the issue

How To Test?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Screenshots (if applicable):

Please add any screenshots that illustrate your changes.

Copy link
Collaborator

@eriysd eriysd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@viiiiiicccky viiiiiicccky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Owner

@natapokie natapokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great victor! thanks for doing the refactor, just left some very small comments :)

client/components/likes/likes.tsx Outdated Show resolved Hide resolved
Copy link
Owner

@natapokie natapokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@natapokie natapokie enabled auto-merge (squash) September 4, 2024 14:25
@natapokie natapokie merged commit a74d9ee into main Sep 4, 2024
1 check passed
@natapokie natapokie deleted the likes-code-cleanup branch September 4, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants