Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

34 add photo thumbnail to the UI #37

Merged
merged 8 commits into from
Sep 9, 2024

Conversation

viiiiiicccky
Copy link
Collaborator

@viiiiiicccky viiiiiicccky commented Sep 5, 2024

Description

**Fixes #34 **

  • move likes to the left corner
  • add small photo thumbnail to the right corder

Documentation Used

Please list any documentation or resources that were referenced while making these changes.

  • Documentation A
  • Documentation B

Issues Faced and Resolutions

Please describe any issues you encountered during development and how you resolved them.

  • Issue: Description of the issue
    • Resolution: Steps taken to resolve the issue

How To Test?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • run client and server:
  • photo thumbnail should show up in the top right corner
  • photo should disappear after likes and comments are done
  • likes component should now be on the left side

Screenshots (if applicable):

Screenshot 2024-09-05 at 2 30 18 PM

Copy link
Owner

@natapokie natapokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great vicky!
left one tiny comment about this warning showing up in the console, could you check and see if it's happening on your end too?

client/components/photo/photo.tsx Outdated Show resolved Hide resolved
Copy link
Owner

@natapokie natapokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks vicky!
another quick note to handle later -- lets check with the prof to see if he wants the photo thumbnail to be displayed/not displayed when we get "no person found" from the API

Copy link
Collaborator

@eriysd eriysd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@vicliu2001 vicliu2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@vicliu2001 vicliu2001 merged commit 82ae7eb into main Sep 9, 2024
1 check passed
@vicliu2001 vicliu2001 deleted the 34-add-photo-thumbnail-to-the-ui branch September 9, 2024 23:25
eriysd pushed a commit that referenced this pull request Sep 10, 2024
* move likes to the left corner

* add photo thumbnail to the top right corner

* add photo thumbnail to the top right corner

* making photo thumbnail smaller

* small fix for comments flow making sure it flows from the top on a longer screen

* fixing likes, making sure they are at the left side

* increasing margins

---------

Co-authored-by: Vicky Chen <chenpanj@amazon.com>
Co-authored-by: Natalie Chan <natapoke2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add photo thumbnail to the ui
4 participants