-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
34 add photo thumbnail to the UI #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great vicky!
left one tiny comment about this warning showing up in the console, could you check and see if it's happening on your end too?
…/natapokie/ai-fashion-mirror into 34-add-photo-thumbnail-to-the-ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! thanks vicky!
another quick note to handle later -- lets check with the prof to see if he wants the photo thumbnail to be displayed/not displayed when we get "no person found" from the API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
* move likes to the left corner * add photo thumbnail to the top right corner * add photo thumbnail to the top right corner * making photo thumbnail smaller * small fix for comments flow making sure it flows from the top on a longer screen * fixing likes, making sure they are at the left side * increasing margins --------- Co-authored-by: Vicky Chen <chenpanj@amazon.com> Co-authored-by: Natalie Chan <natapoke2@gmail.com>
Description
**Fixes #34 **
Documentation Used
Please list any documentation or resources that were referenced while making these changes.
Issues Faced and Resolutions
Please describe any issues you encountered during development and how you resolved them.
How To Test?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Screenshots (if applicable):