Validate vector geometry types #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlys
commented
Oct 18, 2023
| @@ -3507,34 +3507,6 @@ def validate(args, limit_to=None): | |||
| invalid_keys = validation.get_invalid_keys(validation_warnings) | |||
| sufficient_keys = validation.get_sufficient_keys(args) | |||
|
|
|||
| if 'shelf_contour_vector_path' not in invalid_keys: | |||
There was a problem hiding this comment.
This is now redundant to validation.validate.
emlys
commented
Oct 18, 2023
| def test_validate_bad_aoi_incorrect_proj_units(self): | ||
| """WaveEnergy: test validating AOI vector with incorrect units.""" | ||
| from natcap.invest import wave_energy, validation | ||
|
|
There was a problem hiding this comment.
These tests aren't specific to wave energy, and the same thing is covered in the validation tests. I removed them because the sample data vectors they use have the wrong geometry type, which now breaks.
dcdenu4
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1374
Checklist