Skip to content

UCM: skip building vector features with no geometry #1401 #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2023
Merged

UCM: skip building vector features with no geometry #1401 #1436

merged 1 commit into from
Oct 24, 2023

Conversation

emlys
Copy link
Member

@emlys emlys commented Oct 23, 2023 •
edited
Loading

Description

Fixes #1401
This is a simple fix for this specific issue. A more general solution could come in a future rework of validation / input preprocessing.

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

@emlys emlys requested a review from davemfish October 23, 2023 21:08
@emlys emlys marked this pull request as ready for review October 23, 2023 21:08
davemfish
davemfish approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@davemfish davemfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix!

@davemfish davemfish merged commit c80771e into natcap:main Oct 24, 2023
@emlys emlys deleted the bugfix/1401 branch October 3, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davemfish davemfish davemfish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Urban Cooling errors on buildings vector emtpy geometry
2 participants
@emlys @davemfish