enable manual trigger for autorelease part 2 #1493 #1496
Conversation
| @@ -58,8 +70,6 @@ jobs: | |||
| # move the artifacts out of the folders | |||
| mv artifacts/*/* artifacts | |||
| rm -rf artifacts/Wheel* | |||
| # verify that all 6 wheels are there | |||
| if [ `find artifacts/* | wc -l` -ne 6 ]; then exit 1; fi | |||
There was a problem hiding this comment.
Without this check, if we change the name of the wheel artifacts, and forget to update it here, then the release will proceed without the necessary wheels. It seems like you can upload files to a release after it's published, so this shouldn't be a critical issue.
There was a problem hiding this comment.
Okay, that sounds good.
Actually it has me thinking that the more dangerous part is the artifacts for PyPI, since we can't modify that release after it's published. Like what if we changed the artifact names from "Wheel for *". We might not have any wheels downloaded, but we might still call twine upload artifacts/natcap.invest* with the source distribution natcap.invest....tgz available.
There was a problem hiding this comment.
This looks good, thanks, @emlys . In the event we accidentally trigger this without doing part 1, things should fail when it tries to find the non-existent Actions run for the tag.
Your comment about the potential for release artifact name-changes made me think about that case for the PyPI artifacts. There might be a fail-case to prevent there. But we don't necessarily need to make any more changes to this workflow right now. What do you think?
| @@ -58,8 +70,6 @@ jobs: | |||
| # move the artifacts out of the folders | |||
| mv artifacts/*/* artifacts | |||
| rm -rf artifacts/Wheel* | |||
| # verify that all 6 wheels are there | |||
| if [ `find artifacts/* | wc -l` -ne 6 ]; then exit 1; fi | |||
There was a problem hiding this comment.
Okay, that sounds good.
Actually it has me thinking that the more dangerous part is the artifacts for PyPI, since we can't modify that release after it's published. Like what if we changed the artifact names from "Wheel for *". We might not have any wheels downloaded, but we might still call twine upload artifacts/natcap.invest* with the source distribution natcap.invest....tgz available.
|
@davemfish my understanding is you can upload additional files to a PyPI release too. On testpypi I am able to add another file after the first upload to a particular release. |
Ahh okay, great! Thanks for correcting me, I was blindly assuming it was not possible because of the general strictness of things on PyPI. |
Description
Fixes #1493, fixes #1494
Unfortunately there's no simple way to test these changes. I did confirm that the trigger works on my fork.
Checklist