Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for failing Docker builds #1561

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Bugfix for failing Docker builds #1561

merged 4 commits into from
Apr 22, 2024

Conversation

davemfish
Copy link
Contributor

Make sure we're building wheels that are compatible with the conda environment in which we install them.
Fixes #1560

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

@davemfish davemfish requested a review from phargogh April 22, 2024 17:19
phargogh
phargogh approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@phargogh phargogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, makes sense to me!

@phargogh phargogh merged commit 55804f9 into natcap:main Apr 22, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phargogh phargogh phargogh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Container builds are failing
2 participants
@davemfish @phargogh