Correcting viewshed behavior on M1 with a compiler flag #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See llvm/llvm-project#91824 for the thread with the llvm devs. RE:natcap#1562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the incorrect viewshed behavior patched in #1564 was because of a change in the default value of a parameter in clang-14. Deliberately restoring the parameter value to the clang-13 default value corrects the issue.
See llvm/llvm-project#91824 for the thread with the llvm devs. I'm still hoping to find out why this is an issue on ARM64 in the first place and not on x86_64.
RE:#1562
Checklist