Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections to args spec regarding evapotranspiration and preciptation #1716

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

davemfish
Copy link
Contributor

Fixes #1693
Fixes #1694

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

"type": "raster",
"bands": {
1: {
"type": "number",
"units": u.millimeter
}
},
"about": gettext("Map of evapotranspiration values.")
"about": gettext("Map of reference evapotranspiration values.")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the 3 models that use spec_utils.ET0 all expect "reference" evapotranspiration. They are SWY, Urban Cooling, and AWY.

@davemfish davemfish requested a review from emlys December 17, 2024 20:34
Copy link
Member

@emlys emlys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davemfish!

@emlys emlys merged commit f3c2a55 into natcap:main Dec 17, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SWY Data Needs updates to :investspec: investspec "evapotranspiration" wording needs to be changed
2 participants