Plugin install: use micromamba to make sure git is available #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlys
changed the title
3 tasks
dcdenu4
requested changes
Jan 24, 2025
| ['clone', '--depth', '1', '--no-checkout', pluginURL, tmpPluginDir] | ||
| micromamba, | ||
| ['run', '--prefix', `"${baseEnvPrefix}"`, | ||
| 'git', 'clone', '--depth', '1', '--no-checkout', pluginURL, tmpPluginDir] |
There was a problem hiding this comment.
I haven't really tested this out myself on a bare bones VM, but do you think we'll need to set any basic git configuration, like username, to avoid any git prompts when calling git clone?
There was a problem hiding this comment.
Would that be the same as #1712? I tried to reproduce the issue by temporarily renaming my .gitconfig and confirming that my user.name was no longer set in the output of git config --list. I didn't get any prompts during plugin installation. Maybe it only affects windows?
There was a problem hiding this comment.
Okay, thanks for trying to test that out. For this PR I think it's okay to see if we come across it in the wild and can take it up from there.
dcdenu4
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1713
Creates an
invest_baseenvironment that contains git, and runs the subsequent git commands in that env, so we don't have to assume that git is available on the system.Also specifies a prefix (path) for the base and plugin environments, rather than using the
--name. This resolves a warning I was seeing about no root prefix specified - and keeps the invest-specific environments contained in the workbench resources directory, rather than mixing with other envs the user might have in the default location. Also removes the need to look up the env location inmamba info.Also throwing in a fix for #1652, since it's so small - just read in the conda dependencies from a pyproject.toml configuration, rather than hard-coding.
Checklist