Skip to content

Include gaps sizes when checking for minimum parent size #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include gaps sizes when checking for minimum parent size #758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions packages/splitjs/src/split.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,18 @@ const Split = (idsOption, options = {}) => {
return sizesToTrim
}

if (minSizes.reduce((a, b) => a + b, 0) > parentSize) {
const gutterSizes = sizesToTrim.map((_, i) => getGutterSize(
gutterSize,
i === 0,
i === sizesToTrim.length - 1,
gutterAlign,
))

// Ensure parent element has enough space to contain the adjusted sizes
const gutterSizesSum = gutterSizes.reduce((a, b) => a + b, 0)
const minSizesSum = minSizes.reduce((a, b) => a + b, gutterSizesSum)

if (minSizesSum > parentSize) {
return sizesToTrim
}

Expand All @@ -404,13 +415,7 @@ const Split = (idsOption, options = {}) => {
const pixelSizes = sizesToTrim.map((size, i) => {
// Convert requested percentages to pixel sizes
const pixelSize = (parentSize * size) / 100
const elementGutterSize = getGutterSize(
gutterSize,
i === 0,
i === sizesToTrim.length - 1,
gutterAlign,
)
const elementMinSize = minSizes[i] + elementGutterSize
const elementMinSize = minSizes[i] + gutterSizes[i]

// If element is too smal, increase excess pixels by the difference
// and mark that it has no pixels to spare
Expand Down